Navigation: Fix TS problems and make TS improvements in demos#32152
Merged
dmlvr merged 26 commits intoDevExpress:26_1from Jan 13, 2026
Merged
Navigation: Fix TS problems and make TS improvements in demos#32152dmlvr merged 26 commits intoDevExpress:26_1from
dmlvr merged 26 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes TypeScript problems in React demos for VectorMap, FloatingActionButton, and Localization components, enabling the removal of exclusions from tsconfig.react-check.json.
Changes:
- Added TypeScript type definitions for VectorMap data modules and improved type safety across VectorMap demos
- Enhanced TypeScript types in FloatingActionButton demo with proper ref typing and data structure definitions
- Added global TypeScript declarations for Globalize and JSON imports in Localization demo
- Changed tooltip functions to return empty objects instead of null for consistency
- Added proper ref types and optional chaining for component instance access
Reviewed changes
Copilot reviewed 36 out of 48 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
apps/demos/tsconfig.react-check.json |
Removed exclusions for FloatingActionButton, VectorMap, and Localization demos now that TS issues are fixed |
apps/demos/Demos/VectorMap/**/React/devextreme-vectormap-data.d.ts |
Added type definitions for GeoJSON world map data (multiple files) |
apps/demos/Demos/VectorMap/**/React/data.ts |
Added type definitions for GDP and population data structures |
apps/demos/Demos/VectorMap/**/React/App.tsx |
Improved types with proper casting and optional chaining |
apps/demos/Demos/VectorMap/**/React/TooltipTemplate.tsx |
Added types for tooltip template components (with issues) |
apps/demos/Demos/VectorMap/**/React/PieChartComponent.tsx |
Added proper prop interfaces for PieChart components |
apps/demos/Demos/VectorMap/**/ReactJs/*.js |
Applied consistent changes to JavaScript versions (return {}, optional chaining) |
apps/demos/Demos/FloatingActionButton/Overview/React/data.ts |
Added comprehensive type definitions for direction configuration |
apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx |
Added proper ref typing and improved type safety |
apps/demos/Demos/Localization/UsingGlobalize/React/global.d.ts |
Added global type declarations for third-party modules |
apps/demos/Demos/VectorMap/TooltipsCustomization/React/TooltipTemplate.tsx
Outdated
Show resolved
Hide resolved
pharret31
reviewed
Jan 12, 2026
pharret31
reviewed
Jan 12, 2026
pharret31
reviewed
Jan 12, 2026
pharret31
reviewed
Jan 12, 2026
apps/demos/Demos/VectorMap/TooltipsCustomization/React/TooltipTemplate.tsx
Outdated
Show resolved
Hide resolved
pharret31
reviewed
Jan 12, 2026
Contributor
pharret31
left a comment
pharret31
left a comment
There was a problem hiding this comment.
Some fixes are required
apps/demos/Demos/VectorMap/TooltipsCustomization/React/PieChartComponent.tsx
Outdated
Show resolved
Hide resolved
pharret31
approved these changes
Jan 13, 2026
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Jan 13, 2026
dmlvr
added a commit
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.